Add async_search get and delete APIs to HLRC #53828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Search/Search
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
This commit adds the "_async_searhc" get and delete APIs to the AsyncSearchClient in the High Level Rest Client. Relates to elastic#49091
cbuescher
force-pushed
the
aync-search-get-hlrc
branch
from
2be7a0a to
e98a619
Compare
jimczi
reviewed
Mar 19, 2020
...-high-level/src/main/java/org/elasticsearch/client/asyncsearch/DeleteAsyncSearchRequest.java
Outdated
Show resolved
Hide resolved
...est-high-level/src/main/java/org/elasticsearch/client/asyncsearch/GetAsyncSearchRequest.java
Outdated
Show resolved
Hide resolved
...est-high-level/src/main/java/org/elasticsearch/client/asyncsearch/GetAsyncSearchRequest.java
Outdated
Show resolved
Hide resolved
...est-high-level/src/main/java/org/elasticsearch/client/asyncsearch/GetAsyncSearchRequest.java
Show resolved
Hide resolved
cbuescher
force-pushed
the
aync-search-get-hlrc
branch
from
10261bf to
28b307a
Compare
cbuescher
force-pushed
the
aync-search-get-hlrc
branch
from
2eca524 to
9266287
Compare
jimczi
approved these changes
Mar 23, 2020
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left one comment regarding the naming in the AsyncSearchClient, LGTM otherwise.
client/rest-high-level/src/test/java/org/elasticsearch/client/asyncsearch/AsyncSearchIT.java
Outdated
Show resolved
Hide resolved
| * See <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/async-search.html"> the docs</a> for more. | ||
| * | ||
| */ | ||
| public AsyncSearchResponse getAsyncSearch(GetAsyncSearchRequest request, RequestOptions options) throws IOException { |
Contributor
There was a problem hiding this comment.
I wonder if we can rename into get and getAsync since we're already inside the AsyncSearchClient ?
Member
Author
There was a problem hiding this comment.
Sounds good, no problem with that...
| * @return the response | ||
| * @throws IOException in case there is a problem sending the request or parsing back the response | ||
| */ | ||
| public AcknowledgedResponse deleteAsyncSearch(DeleteAsyncSearchRequest request, RequestOptions options) throws IOException { |
Contributor
There was a problem hiding this comment.
Same here, delete should be enough ?
| * @param listener the listener to be notified upon request completion | ||
| * @return cancellable that may be used to cancel the request | ||
| */ | ||
| public Cancellable deleteAsyncSearchAsync(DeleteAsyncSearchRequest request, RequestOptions options, |
| return restHighLevelClient.performRequestAsyncAndParseEntity(request, AsyncSearchRequestConverters::deleteAsyncSearch, options, | ||
| AcknowledgedResponse::fromXContent, listener, emptySet()); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We could also rename submitAsyncSearch into submit and submitAsync ?
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Mar 23, 2020
This commit adds the "_async_searhc" get and delete APIs to the AsyncSearchClient in the High Level Rest Client. Relates to elastic#49091 Backport of elastic#53828
cbuescher
pushed a commit
that referenced
this pull request
Mar 23, 2020
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the "_async_searhc" get and delete APIs to the
AsyncSearchClient in the High Level Rest Client.
Relates to #49091