value type, unmapped fields, scripting, missing param tests for stats agg #53768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for supported ValuesSourceTypes, unmapped fields, scripting, and the missing param. The tests for unmapped fields and scripting are migrated from the StatsIT integration test
andyb-elastic
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
polyfractal
approved these changes
Mar 23, 2020
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
Left a comment about AbstractNumericTestCase but otherwise LGTM! <3
| assertThat(Double.isNaN(stats.getAvg()), is(true)); | ||
| } | ||
|
|
||
| /** this test was moved to {@link StatsAggregatorTests#testUnmapped()} */ |
Contributor
There was a problem hiding this comment.
Hmm, how about making these non-abstract in AbstractNumericTestCase, that way we can just delete them entirely? I don't think we'll be extending AbstractNumericTestCase anymore in the future and it will eventually go away, so probably ok to have concrete "no-op" implementations to make the transition time cleaner.
WDYT?
26 tasks
andyb-elastic
added a commit
to andyb-elastic/elasticsearch
that referenced
this pull request
Apr 1, 2020
Adds tests for supported ValuesSourceTypes, unmapped fields, scripting, and the missing param. The tests for unmapped fields and scripting are migrated from the StatsIT integration test
andyb-elastic
added a commit
that referenced
this pull request
Apr 2, 2020
Adds tests for supported ValuesSourceTypes, unmapped fields, scripting, and the missing param. The tests for unmapped fields and scripting are migrated from the StatsIT integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for supported ValuesSourceTypes, unmapped fields, scripting,
and the missing param. The tests for unmapped fields and scripting are
migrated from the StatsIT integration test