Add REST API for ComponentTemplate CRUD #53558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to elastic#53101
dakrone
added
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
martijnvg
approved these changes
Mar 16, 2020
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
I left a few small comments, otherwise LGTM
...va/org/elasticsearch/action/admin/indices/template/delete/DeleteComponentTemplateAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
...n/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateResponse.java
Outdated
Show resolved
Hide resolved
probakowski
approved these changes
Mar 16, 2020
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
Few comments from my side, otherwise LGTM 👍
...in/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
...org/elasticsearch/action/admin/indices/template/get/TransportGetComponentTemplateAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/action/admin/indices/template/put/PutComponentTemplateRequest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 17, 2020
* Add REST API for ComponentTemplate CRUD This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to elastic#53101 Co-authored-by: Elastic Machine <[email protected]>
dakrone
added a commit
that referenced
this pull request
Mar 17, 2020
* Add REST API for ComponentTemplate CRUD This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing ComponentTemplateMetadata into the cluster state metadata. These APIs are currently only available behind a feature flag system property - `es.itv2_feature_flag_registered`. Relates to #53101 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This was referenced Mar 18, 2020
jrodewig
added a commit
that referenced
this pull request
Mar 20, 2020
The following API spec files contain a link to a not-yet-created docs page for the data stream APIs: * [indices.create_data_stream.json][0] * [indices.delete_data_stream.jsonn][1] * [indices.get_data_streams.json][2] The Elaticsearch-JS client uses these spec files to create their docs. This created a broken link in the Elaticsearch-JS, which has broken the docs build. This PR adds a temporary redirect for the docs page. This redirect should be removed when the actual API docs are added. [0]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.create_data_stream.json [1]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.delete_data_stream.json [2]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_streams.json Relates to #53558. CC @martijnvg
jrodewig
added a commit
that referenced
this pull request
Mar 20, 2020
The following API spec files contain a link to a not-yet-created docs page for the data stream APIs: * [indices.create_data_stream.json][0] * [indices.delete_data_stream.jsonn][1] * [indices.get_data_streams.json][2] The Elaticsearch-JS client uses these spec files to create their docs. This created a broken link in the Elaticsearch-JS, which has broken the docs build. This PR adds a temporary redirect for the docs page. This redirect should be removed when the actual API docs are added. [0]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.create_data_stream.json [1]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.delete_data_stream.json [2]: https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_streams.json Relates to #53558. CC @martijnvg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Put/Get/DeleteComponentTemplate APIs that allow inserting, retrieving, and removing
ComponentTemplateMetadata into the cluster state metadata.
These APIs are currently only available behind a feature flag system property -
es.itv2_feature_flag_registered.Relates to #53101