Rename AtomicFieldData to LeafFieldData #53554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conforms with lucene's LeafReader naming convention, and matches other per-segment structures in elasticsearch.
romseygeek
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
approved these changes
Mar 16, 2020
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @romseygeek, renaming makes sense.
| import java.util.Collections; | ||
|
|
||
| final class BytesBinaryDVAtomicFieldData implements AtomicFieldData { | ||
| final class BytesBinaryDVLeafFieldData implements LeafFieldData { |
Contributor
There was a problem hiding this comment.
nit: ScriptDocValues.java in a comment still mentions the old name of this class, would be nice to change the comment as well.
romseygeek
force-pushed
the
refactoring/atomicfielddata
branch
from
2057b95 to
8552eb8
Compare
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
romseygeek
added a commit
that referenced
this pull request
Mar 17, 2020
This conforms with lucene's LeafReader naming convention, and matches other per-segment structures in elasticsearch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conforms with lucene's LeafReader naming convention, and
matches other per-segment structures in elasticsearch.