migrate tests from MissingIT to MissingAggregatorTests #53448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the remaining tests for the missing aggregation into its AggregatorTestCase out of its integration test and remove the IT For elastic#42893
andyb-elastic
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
26 tasks
nik9000
reviewed
Mar 12, 2020
| } | ||
| }, | ||
| internalMissing -> { | ||
| (Consumer<InternalMissing>) internalMissing -> { |
Member
There was a problem hiding this comment.
I'm not sure about this, but could you write (InternalMissing internalMissing) -> { instead of the cast?
Contributor
Author
There was a problem hiding this comment.
That is much better, thanks
| final IndexSearcher indexSearcher = newSearcher(indexReader, true, true); | ||
| final MappedFieldType[] fieldTypesArray = fieldTypes.toArray(new MappedFieldType[0]); | ||
| final InternalMissing missing; | ||
| final I missing; |
Member
There was a problem hiding this comment.
Maybe call it result instead of missing because it isn't always InternalMissing.
46 tasks
andyb-elastic
added a commit
to andyb-elastic/elasticsearch
that referenced
this pull request
Apr 1, 2020
Move the remaining tests for the missing aggregation into its AggregatorTestCase out of its integration test and remove the IT
andyb-elastic
added a commit
that referenced
this pull request
Apr 2, 2020
Move the remaining tests for the missing aggregation into its AggregatorTestCase out of its integration test and remove the IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the remaining tests for the missing aggregation into its AggregatorTestCase out of its integration test and remove the IT. Figured this was worth doing while working on coverage in this area
For #42893