Use exclusiveContent gradle feature for jdk and distro downloads #53358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jdk and distribution download plugins create fake ivy repositories, and use group based repository filtering to ensure no other artifacts try to resolve against the fake repos. Currently this works by adding a blanket exclude to all repositories for the given group name. This commit changes to using the new exclusiveContent feature in Gradle to do the exclusion.
rjernst
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
1 similar comment
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
rjernst
added a commit
that referenced
this pull request
Mar 11, 2020
) The jdk and distribution download plugins create fake ivy repositories, and use group based repository filtering to ensure no other artifacts try to resolve against the fake repos. Currently this works by adding a blanket exclude to all repositories for the given group name. This commit changes to using the new exclusiveContent feature in Gradle to do the exclusion.
rjernst
added a commit
that referenced
this pull request
Mar 11, 2020
) The jdk and distribution download plugins create fake ivy repositories, and use group based repository filtering to ensure no other artifacts try to resolve against the fake repos. Currently this works by adding a blanket exclude to all repositories for the given group name. This commit changes to using the new exclusiveContent feature in Gradle to do the exclusion.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 13, 2020
The maven coordinates for jdks in the jdk download plugin contain a group name local to our build. However, this still needs to be unique in order for the group filtering to a single ivy repository to work. This commit adjusts the group name to include both the jdk vendor as well as major version. Note: this change was already included in the backport of elastic#53358
rjernst
added a commit
that referenced
this pull request
Mar 13, 2020
The maven coordinates for jdks in the jdk download plugin contain a group name local to our build. However, this still needs to be unique in order for the group filtering to a single ivy repository to work. This commit adjusts the group name to include both the jdk vendor as well as major version. Note: this change was already included in the backport of #53358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jdk and distribution download plugins create fake ivy repositories,
and use group based repository filtering to ensure no other artifacts
try to resolve against the fake repos. Currently this works by adding a
blanket exclude to all repositories for the given group name. This
commit changes to using the new exclusiveContent feature in
Gradle to do the exclusion.