Fix null config in SnapshotLifecyclePolicy.toRequest #53328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids NPE when executing SLM policy when no config was provided. Related to elastic#44465 Closes elastic#53171
probakowski
added
>bug
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
Contributor
Author
|
@elasticmachine update branch |
andreidan
approved these changes
Mar 10, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
Thanks for fixing this @probakowski LGTM
dakrone
approved these changes
Mar 10, 2020
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM too, thanks @probakowski
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided. Related to elastic#44465 Closes elastic#53171 Co-authored-by: Elastic Machine <[email protected]>
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided. Related to elastic#44465 Closes elastic#53171 Co-authored-by: Elastic Machine <[email protected]>
probakowski
added a commit
that referenced
this pull request
Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided. Related to #44465 Closes #53171 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
probakowski
added a commit
that referenced
this pull request
Mar 10, 2020
This avoids NPE when executing SLM policy when no config was provided. Related to #44465 Closes #53171 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids NPE when executing SLM policy when no config was provided.
Related to #44465
Closes #53171