Add BlobStoreRepository#writeSnapshotIndexLatestBlob method #53189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
|
@albertzaharovits I think we don't need to make this change in a separate PR do we? (maybe I'm missing the reason for locking this in now?) |
original-brownbear
suggested changes
Mar 6, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
See my comment, I don't see why we need this yet?
Contributor
Author
|
Okay @original-brownbear , thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a new protected method to access (write) the
index.latestblob; there exists already to opposite method to read the said blob. This change permitsBlobStoreRepositoryimplementations to have a different access behavior, compared to the other blobs, for the specialindex.latestblob.NB: This change might not be REQUIRED for the encrypted repository, given the latest developments #50846 (comment) , but it seems to me like a good-to-have option.