Add more tests in GeoBoundsAggregatorTests #53033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit introduces more thorough field-type support tests as well as tests for unmapped and missing values. relates elastic#42949.
talevy
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
not-napoleon
approved these changes
Mar 3, 2020
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. I would like to address the naming question on testUnmappedWithNoDocs, but the rest of the comments are just nits that you can accept or ignore as you like.
...er/src/test/java/org/elasticsearch/search/aggregations/metrics/GeoBoundsAggregatorTests.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/elasticsearch/search/aggregations/metrics/GeoBoundsAggregatorTests.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/elasticsearch/search/aggregations/metrics/GeoBoundsAggregatorTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
thanks Mark, updated! |
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces more thorough field-type support tests
as well as tests for unmapped and missing values.
relates #42949.