Resolve runtime SP model from index doc #52985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a `SamlServiceProviderResolver` that can build a `SamlServiceProvider` object for a given entity-id, based on the document model stored in `SamlServiceProviderDocument`. This resolver includes a cache that is aware of document versioning (seqNo, primaryTerm) and avoids JSON parsing and object construction if the document has not changed since last use.
Collaborator
|
Pinging @elastic/es-security (:Security/Security) |
# Conflicts: # x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/authn/SamlAuthnRequestValidator.java # x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/idp/CloudIdp.java # x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/idp/SamlIdentityProvider.java # x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/sp/CloudServiceProvider.java # x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/sp/SamlServiceProvider.java # x-pack/plugin/identity-provider/src/test/java/org/elasticsearch/xpack/idp/saml/authn/SamlAuthnRequestValidatorTests.java
jkakavas
reviewed
Mar 3, 2020
Contributor
jkakavas
left a comment
jkakavas
left a comment
There was a problem hiding this comment.
LGTM with the proposed change for validateSignature method signature
...provider/src/main/java/org/elasticsearch/xpack/idp/saml/authn/SamlAuthnRequestValidator.java
Outdated
Show resolved
Hide resolved
...-provider/src/main/java/org/elasticsearch/xpack/idp/saml/sp/SamlServiceProviderResolver.java
Show resolved
Hide resolved
...-provider/src/main/java/org/elasticsearch/xpack/idp/saml/sp/SamlServiceProviderResolver.java
Show resolved
Hide resolved
jkakavas
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
SamlServiceProviderResolverthat can build aSamlServiceProviderobject for a given entity-id, based on thedocument model stored in
SamlServiceProviderDocument.This resolver includes a cache that is aware of document versioning
(seqNo, primaryTerm) and avoids JSON parsing and object construction
if the document has not changed since last use.