Skip to content

Remove TODO in IndexNameExpressionResolver #52963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Remove TODO in IndexNameExpressionResolver #52963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions server/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,8 +680,6 @@ public List<String> resolve(Context context, List<String> expressions) {
return resolveEmptyOrTrivialWildcard(options, metaData);
}

// TODO: Fix API to work with sets rather than lists since we need to convert to sets
// internally anyway.
Set<String> result = innerResolve(context, expressions, options, metaData);

if (result == null) {
Expand Down
4 changes: 4 additions & 0 deletions ...er/src/test/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolverTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ public void testIndexOptionsWildcardExpansion() {
assertEquals(1, results.length);
assertEquals("bar", results[0]);

results = indexNameExpressionResolver.concreteIndexNames(context, "*", "-foo", "*");
assertEquals(3, results.length);
assertThat(results, arrayContainingInAnyOrder("bar", "foobar", "foo"));

results = indexNameExpressionResolver.concreteIndexNames(context, "-*");
assertEquals(0, results.length);

Expand Down