Deprecate undocumented alternatives to the nodes hot threads API (#52640) #52930

muachilin · 2020-02-27T22:35:47Z

This PR deprecates the undocumented alternatives to the nodes hot threads API.

[issue: #52640]

Update forked repository

cla-checker-service · 2020-02-27T22:35:51Z

💚 CLA has been signed

muachilin · 2020-02-27T22:41:52Z

I have signed the Contribution Agreement but I still cannot pass the checks

jasontedor

Thanks for picking this up. I left a comment.

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

jasontedor

I left a question.

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

jasontedor

I left a few more comments, and also the comment about the deprecated route lookup in the prepareRequest method.

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

jasontedor

I left some comments.

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

Update forked repo

elasticmachine · 2020-03-11T17:16:23Z

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

jasontedor

Thanks, we're getting there now. One more thing, and also can you please sign the CLA?

jasontedor · 2020-03-13T01:28:15Z

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

-
 public class RestNodesHotThreadsAction extends BaseRestHandler {

+    static final String formatDeprecatedMessageWithoutNodeID = "[%s] is a deprecated endpoint. Please use [/nodes/hot_threads] instead.";


These can all be private now.

I have signed the CLA but I did not get any confirmation email or other notification to indicate that I have successfully signed it. Thanks!

jasontedor · 2020-03-13T21:26:23Z

cla/check

jasontedor · 2020-03-14T10:14:24Z

@elasticmachine update branch

@elasticmachine test this please

jasontedor · 2020-03-14T22:56:19Z

@elasticmachine update branch

muachilin · 2020-03-15T12:24:03Z

Okay! Thank you.

jasontedor · 2020-03-15T12:37:37Z

@elasticmachine test this please

muachilin · 2020-03-15T20:51:20Z

@elasticmachine update branch

jasontedor · 2020-03-15T23:32:01Z

@muachilin Only to let you know, only maintainers can trigger CI test runs (as you saw, you can use the bot to update the branch with the latest changes from the target branch though).

jasontedor · 2020-03-15T23:32:08Z

@elasticmachine test this please

muachilin · 2020-03-16T10:23:49Z

I see. This is my first time to handle issues in elastic's OSS. Thanks for your time! 😊

jasontedor · 2020-03-16T11:12:33Z

@elasticmachine update branch

jasontedor · 2020-03-16T11:12:50Z

@elasticmachine test this please

jasontedor

Okay, I was getting ready to merge this in and I noticed one issue. Can you address?

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

muachilin · 2020-03-22T15:58:56Z

@elasticmachine update branch

jasontedor · 2020-03-22T15:59:53Z

@elasticmachine test this please

jasontedor

LGTM!

muachilin · 2020-03-24T03:21:56Z

Thanks!

This commit deprecates various undocumented alternatives to the hot threads API.

jasontedor · 2020-03-24T03:25:10Z

Thanks @muachilin!

muachilin added 4 commits February 27, 2020 21:40

Merge pull request #1 from elastic/master

5cecfc3

Update forked repository

Deprecate undocumented alternatives to the nodes hot threads API

8c144df

Remove unused array of strings

3ce731c

Modify the nodeId in the tests

78f23e1

jasontedor requested changes Feb 27, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

[feat] Override deprecatedRoutes

317e1d0

muachilin requested a review from jasontedor February 28, 2020 16:12

muachilin mentioned this pull request Mar 2, 2020

Deprecate & remove undocumented alternatives to the nodes hot threads API #52640

Closed

jasontedor reviewed Mar 2, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

jasontedor requested changes Mar 2, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

changjenyin reviewed Mar 8, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Show resolved Hide resolved

muachilin added 2 commits March 9, 2020 11:38

Deprecate more routes and remove tests

ca5c7e9

Refactor deprecateRoutes()

842e1f6

muachilin requested a review from jasontedor March 9, 2020 11:00

jasontedor reviewed Mar 11, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

muachilin added 4 commits March 11, 2020 12:52

Update forked elasticsearch

8472ed4

Update forked repo

Use locale version of String.format

31a650b

Use locale version of String.format

fe8638b

Remove tests

f828b75

matriv added the :Core/Infra/REST API REST infrastructure and utilities label Mar 11, 2020

muachilin requested a review from jasontedor March 11, 2020 21:10

jasontedor requested changes Mar 13, 2020

View reviewed changes

Declare string variables as private

c2ca69d

muachilin requested a review from jasontedor March 13, 2020 17:30

muachilin added 2 commits March 15, 2020 13:25

Solve style violation

bc6fb6e

Solve style violation

dc776d4

Merge branch 'master' into deprecate-hot-thread

d900b6b

Merge branch 'master' into deprecate-hot-thread

5f6b8d3

jasontedor requested changes Mar 19, 2020

View reviewed changes

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java Outdated Show resolved Hide resolved

muachilin added 2 commits March 22, 2020 23:56

Modify deprecated message

81b5148

Modify deprecated message

d295478

Merge branch 'master' into deprecate-hot-thread

ad9fe9e

jasontedor approved these changes Mar 24, 2020

View reviewed changes

jasontedor merged commit 7989d67 into elastic:master Mar 24, 2020

jasontedor pushed a commit that referenced this pull request Mar 24, 2020

Deprecate alternatives to the hot threads API (#52930)

b33fbe7

This commit deprecates various undocumented alternatives to the hot threads API.

jasontedor added >deprecation v7.7.0 v8.0.0 labels Mar 24, 2020

codebrain mentioned this pull request Apr 1, 2020

7.7.0 meta ticket elastic/elasticsearch-net#4525

Closed

38 tasks

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021


		public class RestNodesHotThreadsAction extends BaseRestHandler {

		static final String formatDeprecatedMessageWithoutNodeID = "[%s] is a deprecated endpoint. Please use [/nodes/hot_threads] instead.";

Deprecate undocumented alternatives to the nodes hot threads API (#52640) #52930

Deprecate undocumented alternatives to the nodes hot threads API (#52640) #52930

Uh oh!

Conversation

muachilin commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-checker-service bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

muachilin commented Feb 27, 2020

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Mar 11, 2020

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

jasontedor Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

muachilin Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

jasontedor commented Mar 13, 2020

Uh oh!

jasontedor commented Mar 14, 2020

Uh oh!

jasontedor commented Mar 14, 2020

Uh oh!

muachilin commented Mar 15, 2020

Uh oh!

jasontedor commented Mar 15, 2020

Uh oh!

muachilin commented Mar 15, 2020

Uh oh!

jasontedor commented Mar 15, 2020

Uh oh!

jasontedor commented Mar 15, 2020

Uh oh!

muachilin commented Mar 16, 2020

Uh oh!

jasontedor commented Mar 16, 2020

Uh oh!

jasontedor commented Mar 16, 2020

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

muachilin commented Mar 22, 2020

Uh oh!

jasontedor commented Mar 22, 2020

Uh oh!

jasontedor left a comment

Choose a reason for hiding this comment

Uh oh!

muachilin commented Mar 24, 2020

Uh oh!

jasontedor commented Mar 24, 2020

Uh oh!

muachilin commented Feb 27, 2020 •

edited

Loading

cla-checker-service bot commented Feb 27, 2020 •

edited

Loading