Remove ECast node from the Painless user tree #52915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
rjernst
approved these changes
Mar 2, 2020
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks good, a couple minor comments.
modules/lang-painless/src/main/java/org/elasticsearch/painless/node/AExpression.java
Show resolved
Hide resolved
modules/lang-painless/src/test/java/org/elasticsearch/painless/GeneralCastTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@rjernst Thanks for the review! Will merge as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the ECast node from the user tree, so that there are no structural changes to the user tree making it structurally immutable. All generated casts are now built directly into the ir tree instead. This also removes the
isNullmember variable from AExpression because now an instanceof operator can be used instead of having to pass this information between potentially multiple levels of user tree nodes.Relates to #49869