EQL: Disable field extraction for source return #52884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search (:Search/EQL) |
aleksmaus
approved these changes
Feb 27, 2020
astefan
approved these changes
Feb 28, 2020
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM. Left two minor comments.
|
|
||
| // NB: the sortBuilder takes care of eliminating duplicates | ||
| container.fields().forEach(f -> f.v1().collectFields(sortBuilder)); | ||
| sortBuilder.build(source); |
Contributor
There was a problem hiding this comment.
The sortBuilder is still defined above. Needs removal? Also, the two comments above are not needed anymore.
| String now = DateUtils.nowWithMillisResolution().format(DateTimeFormatter.ISO_DATE_TIME); | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("{"); | ||
| for (int i = 0; i < 250; i++) { |
Contributor
There was a problem hiding this comment.
I would add a comment here explaining the reason for 250 value (that value larger than the 100 doc_values limit in ES). Maybe take the default limit in ES and use here a value made of that limit + 100 or something like that?
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
costin
added a commit
that referenced
this pull request
Feb 28, 2020
Return the whole source of matching events (cherry picked from commit 79ca586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric mappings have lots of mappings which, in case of individual field selection, can easily hit the limit of maximum doc value fields or automatons.
As fields are not used in EQL, this commit disables field extraction and returns the entire source instead.