[ML] Adds the class_assignment_objective parameter to classification #52763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
tveasey
force-pushed
the
add-class-assignment-objective
branch
from
63aa35d to
edfebc2
Compare
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Looks good! A few things to address.
client/rest-high-level/src/main/java/org/elasticsearch/client/ml/dataframe/Classification.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/MachineLearningIT.java
Show resolved
Hide resolved
...in/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Classification.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @dimitris-athanasiou. I've addressed all your comments. Can you take another look? |
Contributor
Author
|
run elasticsearch-ci/bwc |
Contributor
Author
|
run elasticsearch-ci/2 |
dimitris-athanasiou
approved these changes
Mar 12, 2020
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Now just waiting for those green lights!
tveasey
added a commit
that referenced
this pull request
Mar 13, 2020
Until #52763 is backported to 7.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter for classification that enables choosing whether to assign labels to maximise accuracy or to maximise the minimum class recall.
#52427.