append index name for the source of the cluster put-mapping task #52690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbrown
added
:Distributed Coordination/Task Management
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Task Management) |
henningandersen
requested changes
Feb 26, 2020
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
@zhanghezhen thanks for your PR. It looks like we can simplify it a bit, see comments.
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataMappingService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/MetaDataMappingServiceTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine test this please |
Contributor
|
@elasticmachine update branch |
Contributor
|
@elasticmachine test this please |
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM, thanks @zhanghezhen
henningandersen
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are a lot of pending tasks with put-mapping in the cluster, the "_cat/pending_tasks" API result is too simple to quickly know which index is put-mapping.
Since the task desc is obtained from the 'source' field of task, we can append the index name after the source field when pending task is submitted, it is helpful for us to quickly locate the put-mapping index