Refactor Inflexible Snapshot Repository BwC (#52365) #52557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport the version to use for a snapshot instead of whether to use shard generations in the snapshots in progress entry. This allows making upcoming repository metadata changes in a flexible manner in an analogous way to how we handle serialization BwC elsewhere. Also, exposing the version at the repository API level will make it easier to do BwC relevant changes in derived repositories like source only or encrypted.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 20, 2020
Disabling BwC tests so that elastic#52557 can be merged.
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (some unrelated watcher thingy) |
Contributor
Author
|
Jenkins run elasticsearch-ci/packaging-sample-matrix-unix |
2 similar comments
Contributor
Author
|
Jenkins run elasticsearch-ci/packaging-sample-matrix-unix |
Contributor
Author
|
Jenkins run elasticsearch-ci/packaging-sample-matrix-unix |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
original-brownbear
added a commit
that referenced
this pull request
Feb 21, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 21, 2020
Now that elastic#52557 has been merged we can reenable BwC tests.
original-brownbear
added a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport the version to use for a snapshot instead of whether to use shard generations in the snapshots in progress entry. This allows making upcoming repository metadata changes in a flexible manner in an analogous way to how we handle serialization BwC elsewhere.
Also, exposing the version at the repository API level will make it easier to do BwC relevant changes in derived repositories like source only or encrypted.
backport of #52365