Separate translog from index deletion conditions #52556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
original-brownbear
approved these changes
Feb 20, 2020
server/src/main/java/org/elasticsearch/index/translog/Translog.java
Outdated
Show resolved
Hide resolved
This was referenced Feb 20, 2020
dnhatn
added a commit
that referenced
this pull request
Feb 20, 2020
ywelsch
pushed a commit
that referenced
this pull request
Feb 21, 2020
dnhatn
pushed a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 26, 2020
Separates the translog from the index deletion conditions (allowing the translog to be cleaned up more eagerly), and avoids taking the write lock on the translog if no clean-up is actually necessary.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 26, 2020
Adjusts the assertion as we might eagerly clean up translog during resync since elastic#52556 Relates elastic#52556 Closes elastic#52598
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 26, 2020
Adjusts the assertion as we trim translog more eagerly since elastic#52556. Relates elastic#52556 Closes elastic#52148
dnhatn
pushed a commit
that referenced
this pull request
Feb 26, 2020
Separates the translog from the index deletion conditions (allowing the translog to be cleaned up more eagerly), and avoids taking the write lock on the translog if no clean-up is actually necessary.
dnhatn
added a commit
that referenced
this pull request
Feb 26, 2020
dnhatn
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the translog from the index deletion conditions (allowing the translog to be cleaned up more eagerly), and avoids taking the write lock on the translog if no clean-up is actually necessary.