Skip to content

Conversation

@t-ming
Copy link

@t-ming t-ming commented Feb 19, 2020

Pr#21609 modified the slowlog pattern layout trunactes from the end. And the later Pr#31539 adds a useful field x-opaque-id after source. When the query body is long than 10kB, x-opaque-id will be trunacted. Adjust the order of x-opaque-id to avoid being truncated. And any field added in the future should add before source to avoid being truncated.

Change-Id: I5d3f0077e500a317b70bc7298a8fd1e86b320118
@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
8a8c9d2

Please, read and sign the above mentioned agreement if you want to contribute to this project

@ghost
Copy link

ghost commented Feb 19, 2020

Hi @t-ming, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@t-ming t-ming requested a review from jasontedor February 21, 2020 02:31
@t-ming
Copy link
Author

t-ming commented Feb 21, 2020

thanks @jasontedor . I added emial but not sure that cla bot will re check it.

@matriv matriv added the :Core/Infra/Logging Log management and logging utilities label Feb 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@pgomulka
Copy link
Contributor

@elasticmachine ok to test

@pgomulka
Copy link
Contributor

pgomulka commented Feb 21, 2020

@t-ming can you please have a look at this test failure?

org.elasticsearch.index.SearchSlowLogTests.testSlowLogSearchContextPrinterToLog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Logging Log management and logging utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants