Skip to content

[ML] Prepare to hold additional stats in DF Analytics task #52134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

[ML] Prepare to hold additional stats in DF Analytics task #52134

merged 1 commit into from
Feb 11, 2020

Conversation

@dimitris-athanasiou
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou commented Feb 10, 2020

Refactors DataFrameAnalyticsTask to hold a StatsHolder object.
That just has a ProgressTracker for now but this is paving the
way to add additional stats like memory usage, analysis stats, etc.

@dimitris-athanasiou
[ML] Prepare to hold additinal stats in DF Analytics task
1dcbf2f 
Refactors `DataFrameAnalyticsTask` to hold a `StatsHolder` object.
That just has a `ProgressTracker` for now but this is paving the
way to add additional stats like memory usage, analysis stats, etc.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 10, 2020

Pinging @elastic/ml-core (:ml)

hendrikmuhs
hendrikmuhs approved these changes Feb 11, 2020
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou dimitris-athanasiou merged commit 72b84ad into elastic:master Feb 11, 2020
@dimitris-athanasiou dimitris-athanasiou changed the title [ML] Prepare to hold additinal stats in DF Analytics task [ML] Prepare to hold additional stats in DF Analytics task Feb 11, 2020
@dimitris-athanasiou dimitris-athanasiou deleted the prepare-to-hold-additional-stats-df-analytics-task branch February 11, 2020 07:59
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 11, 2020
@dimitris-athanasiou
[7.x][ML] Prepare to hold additional stats in DF Analytics task (elas…
7c18389 
…tic#52134)

Refactors `DataFrameAnalyticsTask` to hold a `StatsHolder` object.
That just has a `ProgressTracker` for now but this is paving the
way to add additional stats like memory usage, analysis stats, etc.

Backport elastic#52134
@dimitris-athanasiou dimitris-athanasiou mentioned this pull request Feb 11, 2020
Merged
dimitris-athanasiou added a commit that referenced this pull request Feb 11, 2020
@dimitris-athanasiou
[7.x][ML] Prepare to hold additional stats in DF Analytics task (#52134…
6086fad 
…) (#52187)

Refactors `DataFrameAnalyticsTask` to hold a `StatsHolder` object.
That just has a `ProgressTracker` for now but this is paving the
way to add additional stats like memory usage, analysis stats, etc.

Backport #52134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml Machine learning >refactoring v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dimitris-athanasiou @elasticmachine @hendrikmuhs @jakelandis