Refactor JvmOptionsParser for testability #52102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prepares the JvmOptionsParser to be more unit testable by refactoring the class to have some input that it pulls from external sources passed in as arguments. We do not change any functionality in this commit, nor add any unit tests, we are only preparing the way.
jasontedor
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
jasontedor
added a commit
that referenced
this pull request
Feb 10, 2020
This commit prepares the JvmOptionsParser to be more unit testable by refactoring the class to have some input that it pulls from external sources passed in as arguments. We do not change any functionality in this commit, nor add any unit tests, we are only preparing the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prepares the JvmOptionsParser to be more unit testable by refactoring the class to have some input that it pulls from external sources passed in as arguments. We do not change any functionality in this commit, nor add any unit tests, we are only preparing the way.