Skip to content

MINOR: a few of improvements #51921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

MINOR: a few of improvements #51921

merged 2 commits into from
Feb 18, 2020

Conversation

@asdf2014
Copy link
Contributor

@asdf2014 asdf2014 commented Feb 5, 2020

No description provided.

@asdf2014
Copy link
Contributor Author

asdf2014 commented Feb 14, 2020

@cbuescher PTAL

@matriv matriv self-assigned this Feb 18, 2020
@matriv
Copy link
Contributor

matriv commented Feb 18, 2020 •
edited
Loading

Hello @asdf2014,

Thank you for your interest in the project and your contribution.
We'll go ahead and proceed with the PR but please check the general guidelines regarding contribution for the next time:

Note that it is unlikely the project will merge refactors for the sake of refactoring. These types of pull
requests have a high cost to maintainers in reviewing and testing with little to no tangible benefit. This
especially includes changes generated by tools. For example, converting all generic interface instances 
to use the diamond operator.

@matriv
Copy link
Contributor

matriv commented Feb 18, 2020

@elasticmachine ok to test

@matriv
Copy link
Contributor

matriv commented Feb 18, 2020

@elasticmachine update branch

@matriv matriv merged commit 9f59900 into elastic:master Feb 18, 2020
matriv pushed a commit that referenced this pull request Feb 18, 2020
@asdf2014 @matriv
Minor code improvements (#51921)
0c4f7dc 
Fix some whitespaces, comments and usage of `this.`.

(cherry picked from commit 9f59900)
@asdf2014 asdf2014 deleted the a_few_of_improvements branch February 18, 2020 15:14
sbourke pushed a commit to sbourke/elasticsearch that referenced this pull request Feb 19, 2020
@asdf2014 @sbourke
Minor code improvements (elastic#51921)
cf49820 
Fix some whitespaces, comments and usage of `this.`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@matriv matriv

Labels

>non-issue v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asdf2014 @matriv @jakelandis @elasticmachine