Skip to content

Fix SnapshotLifecycleRestIT.testFullPolicySnapshot #51769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Fix SnapshotLifecycleRestIT.testFullPolicySnapshot #51769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8adf1c
Fix SnapshotLifecycleRestIT.testFullPolicySnapshot
dakrone Jan 31, 2020
e4c7649
Clarify some wordings
dakrone Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions .../ilm/qa/multi-node/src/test/java/org/elasticsearch/xpack/slm/SnapshotLifecycleRestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import java.util.function.Predicate;
import java.util.stream.Collectors;

import static org.elasticsearch.common.xcontent.XContentFactory.jsonBuilder;
Expand Down Expand Up @@ -104,6 +106,11 @@ public void testFullPolicySnapshot() throws Exception {

createSnapshotPolicy(policyName, "snap", "*/1 * * * * ?", repoId, indexName, true);

// A test for whether the repository's snapshots have any snapshots starting with "snap-"
Predicate<Map<String, Object>> repoHasSnapshot = snapMap -> Optional.ofNullable((String) snapMap.get("snapshot"))
.map(snapName -> snapName.startsWith("snap-"))
.orElse(false);

// Check that the snapshot was actually taken
assertBusy(() -> {
Response response = client().performRequest(new Request("GET", "/_snapshot/" + repoId + "/_all"));
Expand All @@ -112,17 +119,16 @@ public void testFullPolicySnapshot() throws Exception {
snapshotResponseMap = XContentHelper.convertToMap(XContentType.JSON.xContent(), is, true);
}
assertThat(snapshotResponseMap.size(), greaterThan(0));
final Map<String, Object> snapResponse;
try {
Map<String, Object> responseMap = ((List<Map<String, Object>>) snapshotResponseMap.get("responses")).get(0);
List<Map<String, Object>> snapshots = (List<Map<String, Object>>) responseMap.get("snapshots");
assertTrue(snapshots.stream().anyMatch(s -> s.containsKey("snapshot") && s.get("snapshot").toString().startsWith("snap-")));
snapResponse = snapshots.get(0);
} catch (Exception e) {
throw new AssertionError("failed to find snapshot response in " + snapshotResponseMap, e);
}
assertThat(snapResponse.get("indices"), equalTo(Collections.singletonList(indexName)));
Map<String, Object> metadata = (Map<String, Object>) snapResponse.get("metadata");
List<Map<String, Object>> snapResponse = ((List<Map<String, Object>>) snapshotResponseMap.get("responses")).stream()
.peek(m -> logger.info("--> responses: {}", m))
.map(m -> (List<Map<String, Object>>) m.get("snapshots"))
.peek(allReposSnapshots -> logger.info("--> all repository's snapshots: {}", allReposSnapshots))
.filter(allReposSnapshots -> allReposSnapshots.stream().anyMatch(repoHasSnapshot))
.peek(allRepos -> logger.info("--> snapshots with 'snap-' snapshot: {}", allRepos))
.findFirst()
.orElseThrow(() -> new AssertionError("failed to find snapshot response in " + snapshotResponseMap));
assertThat(snapResponse.get(0).get("indices"), equalTo(Collections.singletonList(indexName)));
Map<String, Object> metadata = (Map<String, Object>) snapResponse.get(0).get("metadata");
assertNotNull(metadata);
assertThat(metadata.get("policy"), equalTo(policyName));
});
Expand Down