[ML][Inference] Adds validations for model PUT #51376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
approved these changes
Jan 24, 2020
| @Override | ||
| public void validate() { | ||
| if (this.models.isEmpty()) { | ||
| throw ExceptionsHelper.badRequestException("[trained_models] must not be empty"); |
Contributor
There was a problem hiding this comment.
Would it make sense to use TRAINED_MODELS.getPreferredName() here rather than literal?
| @Override | ||
| public void validate() { | ||
| if (featureNames.isEmpty()) { | ||
| throw ExceptionsHelper.badRequestException("[feature_names] must not be empty for tree model"); |
Contributor
There was a problem hiding this comment.
Would it make sense to use FEATURE_NAMES.getPreferredName() here rather than literal?
benwtrent
deleted the
feature/ml-inference-adding-more-put-validations
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 24, 2020
Adds validations making sure that * `input.field_names` is not empty * `ensemble.trained_models` is not empty * `tree.feature_names` is not empty closes elastic#51354
This was referenced Jan 24, 2020
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 24, 2020
Adds validations making sure that * `input.field_names` is not empty * `ensemble.trained_models` is not empty * `tree.feature_names` is not empty closes elastic#51354
benwtrent
added a commit
that referenced
this pull request
Jan 24, 2020
benwtrent
added a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validations making sure that
input.field_namesis not emptyensemble.trained_modelsis not emptytree.feature_namesis not emptycloses #51354