[ML] Validate classification dependent_variable cardinality is at lea… #51232
Conversation
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Just a few minor comments
There was a problem hiding this comment.
s/limits/constraints
?
There was a problem hiding this comment.
s/Limits/Constraints
?
There was a problem hiding this comment.
There is a "Matchers.empty()" matcher that could be used here.
There was a problem hiding this comment.
There is a "Matchers.empty()" matcher that could be used here.
There was a problem hiding this comment.
Note that this is now necessary as we are checking the field cardinality before we call startAnalytics which refreshes the dest index.
|
@przemekwitek I have addressed all your points plus fixes a bug regarding refreshing of the dest index which was caught by the tests. |
There was a problem hiding this comment.
Should this be reverted?
There was a problem hiding this comment.
Ah, yes of course.
Please see my comment in |
…st two Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails.
dimitris-athanasiou
force-pushed
the
validate-classification-dep-var-cardinality-at-least-two
branch
from
e51393e to
eab85d5
Compare
dimitris-athanasiou
deleted the
validate-classification-dep-var-cardinality-at-least-two
branch
…t lea… (elastic#51232) Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails. Backport of elastic#51232
…t lea… (elastic#51232) Data frame analytics classification currently only supports 2 classes for the dependent variable. We were checking that the field's cardinality is not higher than 2 but we should also check it is not less than that as otherwise the process fails. Backport of elastic#51232
4 participants
…st two
Data frame analytics classification currently only supports 2 classes for the
dependent variable. We were checking that the field's cardinality is not higher
than 2 but we should also check it is not less than that as otherwise the process
fails.