Fix date_histogram serialization bug #51185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I caused a serialization bug in elastic#50873. It is kind of tricky to get: * Run a date_histogram aggregation * On a shard on 7.6 * That shard doesn't return any results * The coordinating node is before 7.6
Member
Author
|
I marked this as non-issue because we have yet to release 7.6.0. |
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
Member
Author
|
I'm targeting this at the 7.6 branch because that was where I found it. I'll drag it forward once merged. |
nik9000
commented
Jan 17, 2020
| // Important: use `rounding` here, not `shardRounding` | ||
| InternalDateHistogram.EmptyBucketInfo emptyBucketInfo = minDocCount == 0 | ||
| ? new InternalDateHistogram.EmptyBucketInfo(rounding, buildEmptySubAggregations(), extendedBounds) | ||
| ? new InternalDateHistogram.EmptyBucketInfo(rounding.withoutOffset(), buildEmptySubAggregations(), extendedBounds) |
Member
Author
There was a problem hiding this comment.
InternalDateHistogram isn't really aware of offset rounding yet so this should be safe to do unconditionally.
Member
Author
|
I'm going to revert the change that made this one so urgent in #51240. |
Member
Author
|
I'll roll this into the "redo" of #50873. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caused a serialization bug in #50873. It is kind of tricky to get: