Begin moving date_histogram to offset rounding (backport of #50873) #50978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0873) We added a new rounding in elastic#50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 20, 2020
…lastic#50873) (elastic#50978)" This reverts commit 9a3d4db. It was subtly broken in ways we didn't have tests for.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 20, 2020
…lastic#50873) (elastic#50978)" This reverts commit 9a3d4db. It was subtly broken in ways we don't have tests for.
nik9000
added a commit
that referenced
this pull request
Jan 20, 2020
nik9000
added a commit
that referenced
this pull request
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new rounding in #50609 that handles offsets to the start and
end of the rounding so that we could support
offsetin thecompositeaggregation. This starts moving
date_histogramto that new offset.