Fix queuing in AsyncLucenePersistedState #50958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
requested changes
Jan 14, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Could we also assert threadPoolExecutor.isShutdown() in onRejection()?
Contributor
Author
yes, I've also removed the |
ywelsch
added a commit
that referenced
this pull request
Jan 14, 2020
The logic in AsyncLucenePersistedState was flawed, unexpectedly queuing up two update tasks in parallel.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The logic in AsyncLucenePersistedState was flawed, unexpectedly queuing up two update tasks in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
AsyncLucenePersistedStatewas flawed, unexpectedly queuing up two update tasks in parallel.Marked as non-issue as it's non-released code.