Skip to content

Fix testSkipRefreshIfShardIsRefreshingAlready #50856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Fix testSkipRefreshIfShardIsRefreshingAlready #50856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a6dee
Fix testSkipRefreshIfShardIsRefreshingAlready
henningandersen Jan 10, 2020
1b8867e
Removed print statement.
henningandersen Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions server/src/test/java/org/elasticsearch/indices/IndexingMemoryControllerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,19 +432,18 @@ protected long getShardWritingBytes(IndexShard shard) {
}
};
int iterations = randomIntBetween(10, 100);
ThreadPoolStats.Stats beforeStats = getRefreshThreadPoolStats();
for (int i = 0; i < iterations; i++) {
controller.forceCheck();
}
assertBusy(() -> {
ThreadPoolStats.Stats stats = getRefreshThreadPoolStats();
assertThat(stats.getQueue(), equalTo(0));
assertThat(stats.getActive(), equalTo(1));
assertThat(stats.getCompleted(), equalTo(beforeStats.getCompleted() + iterations - 1));
});
refreshLatch.get().countDown(); // allow refresh
assertBusy(() -> {
ThreadPoolStats.Stats stats = getRefreshThreadPoolStats();
assertThat(stats.getQueue(), equalTo(0));
assertThat(stats.getActive(), equalTo(0));
assertThat(stats.getCompleted(), equalTo(beforeStats.getCompleted() + iterations));
});
assertThat(shard.refreshStats().getTotal(), equalTo(refreshStats.getTotal() + 1));
closeShards(shard);
Expand Down