Fix Snapshot Repository Corruption in Downgrade Scenarios (#50692) #50797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
@ywelsch @tlrx could I get a quick sanity check on the change I had to make here to make things work in 7.x (change relative to master is: 524af67) Since |
Contributor
Author
|
Thanks Yannick! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 10, 2020
We need the same fix we did in `7.x` (elastic#50797) and only get snapshot status for the current version or older. Otherwise these tests break for e.g.`7.0.1` due to the same index metadata incompatibility. Closes elastic#50819
original-brownbear
added a commit
that referenced
this pull request
Jan 10, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
We need the same fix we did in `7.x` (elastic#50797) and only get snapshot status for the current version or older. Otherwise these tests break for e.g.`7.0.1` due to the same index metadata incompatibility. Closes elastic#50819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces test infrastructure for downgrading a cluster while interacting with a given repository.
It fixes the fact that repository metadata in the new format could be written while there's still older snapshots in the repository that require the old-format metadata to be restorable.
backport of #50692