Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 6, 2020

We need to create a hard-deletes engine in the test with soft-deletes disabled; otherwise, we the min_retained_seqno will be calculated incorrectly.

Closes #50654

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.6.0 labels Jan 6, 2020
@dnhatn dnhatn requested a review from ywelsch January 6, 2020 15:22
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit c2a3eda into elastic:master Jan 6, 2020
@dnhatn dnhatn deleted the fix-hard-deletes-test branch January 6, 2020 16:17
@dnhatn dnhatn removed the v7.6.0 label Jan 6, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
We need to create a hard-deletes engine in the test with soft-deletes 
disabled; otherwise, we the min_retained_seqno will be calculated
incorrectly.

Closes elastic#50654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InternalEngineTests testRecoverFromHardDeletesIndex failure

4 participants