-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Refresh state index before completing data frame analytics job #50322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dimitris-athanasiou
merged 1 commit into
elastic:master
from
dimitris-athanasiou:refresh-state-index-before-completing-dfa-job
Dec 18, 2019
Merged
[ML] Refresh state index before completing data frame analytics job #50322
dimitris-athanasiou
merged 1 commit into
elastic:master
from
dimitris-athanasiou:refresh-state-index-before-completing-dfa-job
Dec 18, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in elastic#50168 and elastic#50313 where the model state appears missing. Closes elastic#50168 Closes elastic#50313
Collaborator
|
Pinging @elastic/ml-core (:ml) |
droberts195
approved these changes
Dec 18, 2019
droberts195
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Dec 18, 2019
…job (elastic#50322) In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in elastic#50168 and elastic#50313 where the model state appears missing. Closes elastic#50168 Closes elastic#50313 Backport of elastic#50322
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Dec 18, 2019
…job (elastic#50322) In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in elastic#50168 and elastic#50313 where the model state appears missing. Closes elastic#50168 Closes elastic#50313 Backport of elastic#50322
dimitris-athanasiou
added a commit
that referenced
this pull request
Dec 18, 2019
…job (#50322) (#50325) In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in #50168 and #50313 where the model state appears missing. Closes #50168 Closes #50313 Backport of #50322
dimitris-athanasiou
added a commit
that referenced
this pull request
Dec 18, 2019
…job (#50322) (#50324) In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in #50168 and #50313 where the model state appears missing. Closes #50168 Closes #50313 Backport of #50322
Contributor
przemekwitek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…lastic#50322) In order to ensure any persisted model state is searchable by the moment the job reports itself as `stopped`, we need to refresh the state index before completing. This should fix the occasional failures we see in elastic#50168 and elastic#50313 where the model state appears missing. Closes elastic#50168 Closes elastic#50313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:ml
Machine learning
>test
Issues or PRs that are addressing/adding tests
v7.5.2
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure any persisted model state is searchable by the moment
the job reports itself as
stopped, we need to refresh the state indexbefore completing.
This should fix the occasional failures we see in #50168 and #50313 where
the model state appears missing.
Closes #50168
Closes #50313