Skip to content

Conversation

@dimitris-athanasiou
Copy link
Contributor

In order to ensure any persisted model state is searchable by the moment
the job reports itself as stopped, we need to refresh the state index
before completing.

This should fix the occasional failures we see in #50168 and #50313 where
the model state appears missing.

Closes #50168
Closes #50313

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in elastic#50168 and elastic#50313 where
the model state appears missing.

Closes elastic#50168
Closes elastic#50313
@dimitris-athanasiou dimitris-athanasiou added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.6.0 v7.5.2 labels Dec 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou dimitris-athanasiou merged commit 4d8d8d9 into elastic:master Dec 18, 2019
@dimitris-athanasiou dimitris-athanasiou deleted the refresh-state-index-before-completing-dfa-job branch December 18, 2019 16:56
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Dec 18, 2019
…job (elastic#50322)

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in elastic#50168 and elastic#50313 where
the model state appears missing.

Closes elastic#50168
Closes elastic#50313

Backport of elastic#50322
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Dec 18, 2019
…job (elastic#50322)

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in elastic#50168 and elastic#50313 where
the model state appears missing.

Closes elastic#50168
Closes elastic#50313

Backport of elastic#50322
dimitris-athanasiou added a commit that referenced this pull request Dec 18, 2019
…job (#50322) (#50325)

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in #50168 and #50313 where
the model state appears missing.

Closes #50168
Closes #50313

Backport of #50322
dimitris-athanasiou added a commit that referenced this pull request Dec 18, 2019
…job (#50322) (#50324)

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in #50168 and #50313 where
the model state appears missing.

Closes #50168
Closes #50313

Backport of #50322
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…lastic#50322)

In order to ensure any persisted model state is searchable by the moment
the job reports itself as `stopped`, we need to refresh the state index
before completing.

This should fix the occasional failures we see in elastic#50168 and elastic#50313 where
the model state appears missing.

Closes elastic#50168
Closes elastic#50313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.5.2 v7.6.0 v8.0.0-alpha1

Projects

None yet

5 participants