-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Rename the remote cluster sniff proxy setting #50299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the remote cluster sniff proxy setting #50299
Conversation
|
Pinging @elastic/es-distributed (:Distributed/Network) |
|
This commit is necessary for #50291. Otherwise the news settings cannot be added. |
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some relevant REST tests failing. I also wonder how the upgrade path for a rolling upgrade will look like.
| final ClusterGetSettingsResponse clusterGetSettingsResponse = ClusterGetSettingsResponse.fromXContent(parser); | ||
| final Settings settings = clusterGetSettingsResponse.getPersistentSettings(); | ||
|
|
||
| logger.error(settings); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
|
After looking into this, I am not sure if using the name proxy is going to work. As I investigated the rolling restart tests I had two concerns:
I am open to any discussions about how to resolve this issue. If there is some safe way to ensure the handling of a removed setting I can go that direction. But we can also consider other names such as |
|
This PR will probably be closed in favor of #50291. |
|
Closing. We are not moving in this direction. |
In order to use the "proxy" name for the new connection mode, the
existing
cluster.remote.cluster_name.proxysetting must be renamedto
cluster.remote.cluster_name.sniff.proxy. This commit implementsthis change and adds a setting upgrader. Since the setting is not
documented, the old setting is immediately removed. Finally, the
settings upgrader infrastructure is modified so that settings that are
not registered with the cluster can be upgraded.