[ML] retry bulk indexing of state docs #50149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
davidkyle
approved these changes
Dec 13, 2019
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
One nit is that ResultsPersisterService is a general class now used for state as well as results now, it doesn't know anything about anomaly detector results classes. Maybe it is just a PersistenceService or RetryPersistenceService
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Dec 13, 2019
This exchanges the direct use of the `Client` for `ResultsPersisterService`. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.
benwtrent
added a commit
that referenced
this pull request
Dec 13, 2019
|
@dimitris-athanasiou in case you didn't notice, this PR also covers retries for indexing data frame analytics state, as the state is persisted by the same |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This exchanges the direct use of the `Client` for `ResultsPersisterService`. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exchanges the direct use of the
ClientforResultsPersisterService. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.closes #50143