"CONTAINS" support for BKD-backed geo_shape and shape fields #50141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucene 8.4 added support for "CONTAINS", therefore in this commit those changes are integrated in Elasticsearch. This commit contains as well a bug fix when querying with a geometry collection with "DISJOINT" relation.
iverase
added
>enhancement
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
jpountz
reviewed
Dec 12, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Do we need to disallow this relation on pre-7.6 indices?
server/src/main/java/org/elasticsearch/index/query/VectorGeoShapeQueryProcessor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I think we can perform the query as well in 7.5 indexes but not before. |
elasticseatch 7.5.0
Contributor
Author
|
I checked and yes, we started labelling the edges of a polygon in Lucene 8.3 so indexes created in Elasticsearch 7.5.x are fine. I added the check but I need to work out how to test this feature. We can improve the error message as well. |
jpountz
approved these changes
Dec 13, 2019
iverase
added a commit
that referenced
this pull request
Dec 16, 2019
…#50213) Lucene 8.4 added support for "CONTAINS", therefore in this commit those changes are integrated in Elasticsearch. This commit contains as well a bug fix when querying with a geometry collection with "DISJOINT" relation.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…#50141) Lucene 8.4 added support for "CONTAINS", therefore in this commit those changes are integrated in Elasticsearch. This commit contains as well a bug fix when querying with a geometry collection with "DISJOINT" relation.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 8.4 added support for "CONTAINS", therefore in this commit those
changes are integrated in Elasticsearch. This commit contains as well a
bug fix when querying with a geometry collection with "DISJOINT" relation.
Closes #41204