Log attachment generation failures #50080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watcher logs when actions fail in `ActionWrapper`, but failures to generate an attachment are not logged and we thus only know the type of the exception and not where/how it occurred.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
gwbrown
approved these changes
Dec 11, 2019
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy.
henningandersen
added a commit
that referenced
this pull request
Dec 11, 2019
Watcher logs when actions fail in ActionWrapper, but failures to generate an email attachment are not logged and we thus only know the type of the exception and not where/how it occurred.
henningandersen
added a commit
that referenced
this pull request
Dec 11, 2019
Watcher logs when actions fail in ActionWrapper, but failures to generate an email attachment are not logged and we thus only know the type of the exception and not where/how it occurred.
henningandersen
added a commit
that referenced
this pull request
Dec 11, 2019
Watcher logs when actions fail in ActionWrapper, but failures to generate an email attachment are not logged and we thus only know the type of the exception and not where/how it occurred.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Watcher logs when actions fail in ActionWrapper, but failures to generate an email attachment are not logged and we thus only know the type of the exception and not where/how it occurred.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watcher logs when actions fail in
ActionWrapper, but failures togenerate an email attachment are not logged and we thus only know the
type of the exception and not where/how it occurred.