Migrate MinAggregator integration tests to AggregatorTestCase #50053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also renames MinTests to MinAggregationBuilderTests
polyfractal
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
46 tasks
not-napoleon
approved these changes
Dec 11, 2019
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. There's some other cases we could test, like an incorrect type field or weird missing values, but I don't know that we need to do that right now. Long term, it'd be good to come up with a "standard battery" of tests we should apply to all aggs, but this is a great step towards standardized tests!
server/src/test/java/org/elasticsearch/search/aggregations/metrics/MinAggregatorTests.java
Show resolved
Hide resolved
Contributor
Author
|
Added a few more tests for missing, unmapped fields, bad types, bad missing, etc. Happy to add more if you have particular scenarios not covered. :) |
not-napoleon
approved these changes
Dec 13, 2019
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
These tests look great. I can't think of any other cases we urgently need to cover, so let's merge it.
polyfractal
added a commit
that referenced
this pull request
Dec 16, 2019
Also renames MinTests to MinAggregationBuilderTests
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…c#50053) Also renames MinTests to MinAggregationBuilderTests
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42893, this migrates the min aggregator integration tests over to unit tests in AggregatorTestCase.
While I was messing around with the unit tests, I refactored some of the existing unit tests to use the standardized
searchAndReducerather than bespoke version that was in place before.