Make testclusters registry extension name unique #49956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testclusters registory is a singleton extension element added to the root project which tracks which test clusters are used throughout the multi project. But having the same name as the extension used to configure test clusters within each subprojects breaks using a single project for an external plugin. This commit renames the registry extension to make it unique. closes elastic#49787
rjernst
added
>bug
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Member
Author
|
@elasticmachine run elasticsearch-ci/oss-distro-docs |
rjernst
added a commit
that referenced
this pull request
Dec 12, 2019
The testclusters registory is a singleton extension element added to the root project which tracks which test clusters are used throughout the multi project. But having the same name as the extension used to configure test clusters within each subprojects breaks using a single project for an external plugin. This commit renames the registry extension to make it unique. closes #49787
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The testclusters registory is a singleton extension element added to the root project which tracks which test clusters are used throughout the multi project. But having the same name as the extension used to configure test clusters within each subprojects breaks using a single project for an external plugin. This commit renames the registry extension to make it unique. closes elastic#49787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testclusters registory is a singleton extension element added to the
root project which tracks which test clusters are used throughout the
multi project. But having the same name as the extension used to
configure test clusters within each subprojects breaks using a single
project for an external plugin. This commit renames the registry
extension to make it unique.
closes #49787