Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Dec 4, 2019

Reformats the token count limit token filter docs as part of #44726.

Changes

  • Adds a title abbreviation
  • Updates the description and adds a Lucene link
  • Add tip directing users to ignore_above mapping parameter
  • Reformats the parameters section
  • Adds analyze, custom analyzer, and custom filter snippets

@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.6.0 v7.5.1 labels Dec 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporate or ignore as you see fit. :-)

[TIP]
====
The `limit` filter is commonly used to limit the size of document field values
based on _token count_. If you want to limit the size of field values based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first sentence in this tip seems like it belongs in the description as the "why" you want to use this filter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Moved this with 64239c9.

--------------------------------------------------

[[analysis-limit-token-count-tokenfilter-configure-parms]]
==== Configurable parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this come before the Example section? (And maybe include the "basic" example up front?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relocated with c353875.

@jrodewig
Copy link
Contributor Author

Thanks @debadair!

@jrodewig jrodewig merged commit 9907b0a into elastic:master Dec 13, 2019
@jrodewig jrodewig deleted the reformat.limit-token-count-token-filter branch December 13, 2019 13:43
@jrodewig
Copy link
Contributor Author

master: 9907b0a
7.x: cd04021
7.5: 8a200b0

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search Relevance/Analysis How text is split into tokens v7.5.1 v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants