Collect results in a local list when notifying partial results #49828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
jimczi
reviewed
Dec 4, 2019
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks @iverase. I missed the fact that modification could happen before the synchronized call.
We don't want to take concurrent modifications into account since we need to report the shards that are part of the current partial reduce. I opened #49829 to use a different array that is synchronously accessed and modified. This should fix the concurrent issue and the wrong reporting.
Contributor
Author
|
I see, then I close this PR in favour of #49829 |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the list generated by the AtomicArray in ArraySearchPhaseResults but this List is shared between threads and can get nullify. This change collects results in a local list to prevent concurrent issues.
fixes #49778