Stop Copying Bulk HTTP Requests in NIO Networking #49819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as elastic#44564 but for NIO.
original-brownbear
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
Contributor
Author
|
@ywelsch @tbrooks8 could one of you take a look here. This should be trivial to review as it's just the same code we have in the Netty implementation again and I think it would make benchmarks between both implementations easier to compare if we had them aligned again :) Thanks! |
Contributor
Author
|
Thanks Tim! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 24, 2020
Same as elastic#44564 but for NIO.
original-brownbear
added a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #44564 but for NIO.