Fix external integ test zip dep to expect a zip #49813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When external plugin authors use build-tools, their integ tests depend on the integ-test-zip artifact. However, this dependency was broken in 7.5.0 by accidentally removing the `@zip` qualifier on the maven dependency, which works around the fact the pom for the integ-test-zip claims the artifact is a pom instead of zip packaging. This commit restores the workaround of using `@zip` until the pom can be fixed. closes elastic#49787
rjernst
added
>bug
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
added a commit
that referenced
this pull request
Dec 5, 2019
When external plugin authors use build-tools, their integ tests depend on the integ-test-zip artifact. However, this dependency was broken in 7.5.0 by accidentally removing the `@zip` qualifier on the maven dependency, which works around the fact the pom for the integ-test-zip claims the artifact is a pom instead of zip packaging. This commit restores the workaround of using `@zip` until the pom can be fixed. closes #49787
rjernst
added a commit
that referenced
this pull request
Dec 5, 2019
When external plugin authors use build-tools, their integ tests depend on the integ-test-zip artifact. However, this dependency was broken in 7.5.0 by accidentally removing the `@zip` qualifier on the maven dependency, which works around the fact the pom for the integ-test-zip claims the artifact is a pom instead of zip packaging. This commit restores the workaround of using `@zip` until the pom can be fixed. closes #49787
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
When external plugin authors use build-tools, their integ tests depend on the integ-test-zip artifact. However, this dependency was broken in 7.5.0 by accidentally removing the `@zip` qualifier on the maven dependency, which works around the fact the pom for the integ-test-zip claims the artifact is a pom instead of zip packaging. This commit restores the workaround of using `@zip` until the pom can be fixed. closes elastic#49787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When external plugin authors use build-tools, their integ tests depend
on the integ-test-zip artifact. However, this dependency was broken in
7.5.0 by accidentally removing the
@zipqualifier on the mavendependency, which works around the fact the pom for the integ-test-zip
claims the artifact is a pom instead of zip packaging. This commit
restores the workaround of using
@zipuntil the pom can be fixed.closes #49787