[ML] Add optional source filtering during data frame reindexing #49690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
szabosteve
approved these changes
Nov 28, 2019
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
szabosteve
reviewed
Nov 28, 2019
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
droberts195
approved these changes
Nov 28, 2019
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM apart from some typos in the docs
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
szabosteve
reviewed
Nov 28, 2019
|
By the way, I hadn't seen István's review when I was doing mine. |
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsSource.java
Outdated
Show resolved
Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsSource.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/ml/dataframe/extractor/ExtractedFieldsDetectorTests.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
force-pushed
the
data-frame-analytics-source-filtering
branch
from
fa5f926 to
0866358
Compare
This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531
Co-Authored-By: István Zoltán Szabó <[email protected]>
Co-Authored-By: István Zoltán Szabó <[email protected]>
Contributor
Author
|
@elasticmachine update branch |
dimitris-athanasiou
deleted the
data-frame-analytics-source-filtering
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 29, 2019
Until #49690 is backported to 7.x
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 29, 2019
…lastic#49690) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531 Backport of elastic#49690
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 29, 2019
…49690) (#49718) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes #49531 Backport of #49690
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 29, 2019
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 29, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…tic#49690) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Until elastic#49690 is backported to 7.x
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
_sourcesetting under thesourcesetting of a dataframe analytics config. The new
_sourceis reusing the structureof a
FetchSourceContextlikeanalyzed_fieldsdoes. Specifyingincludes and excludes for source allows selecting which fields
will get reindexed and will be available in the destination index.
Closes #49531