Skip to content

Conversation

@csoulios
Copy link
Contributor

This PR fixes a trivial typo error that affects assigning null_value in the GeoPointFieldMapper

It seems that code was pasted from the line above but not fully changed.

It seems that code was pasted but not fully
changed
@csoulios csoulios requested a review from imotov November 27, 2019 13:13
@csoulios csoulios added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Nov 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csoulios

@csoulios
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/default-distro

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csoulios great catch! Any chance you can add a test for it?

@iverase
Copy link
Contributor

iverase commented Nov 27, 2019

+1 for a test

@csoulios
Copy link
Contributor Author

Test is coming :)

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csoulios csoulios merged commit 4b16d50 into elastic:master Nov 27, 2019
@csoulios csoulios deleted the fix/geo_fieldmapper branch November 27, 2019 16:33
csoulios added a commit that referenced this pull request Nov 27, 2019
Backport of #49645 to 7.x
This PR fixes a trivial typo error that affects assigning null_value in the GeoPointFieldMapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants