Skip to content

Conversation

@jrodewig
Copy link
Contributor

Reformats the keep types and keep words token filter docs as part of #44726.

Changes

  • Adds title abbreviations
  • Updates the descriptions and adds Lucene links
  • Reformats parameter definitions
  • Adds analyze and custom analyzer snippets
  • Adds explanations of token types to keep types token filter and tokenizer docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion for an addition, the rest LGTM

.Token types
====
Token types are set by the <<analysis-tokenizers,tokenizer>> when converting
characters to tokens. Token types can vary between tokenizers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth an addition that also certain filters (e.g. synonym filter) can add tokens with a specific type (in that case of SYNONYM type)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great point. Added a note with 5082846.

@jrodewig jrodewig merged commit 6ea54ee into elastic:master Dec 2, 2019
@jrodewig jrodewig deleted the reformat.keep-token-filters branch December 2, 2019 14:22
jrodewig added a commit that referenced this pull request Dec 2, 2019
* Adds title abbreviations
* Updates the descriptions and adds Lucene links
* Reformats parameter definitions
* Adds analyze and custom analyzer snippets
* Adds explanations of token types to keep types token filter and tokenizer docs
jrodewig added a commit that referenced this pull request Dec 2, 2019
* Adds title abbreviations
* Updates the descriptions and adds Lucene links
* Reformats parameter definitions
* Adds analyze and custom analyzer snippets
* Adds explanations of token types to keep types token filter and tokenizer docs
jrodewig added a commit that referenced this pull request Dec 2, 2019
* Adds title abbreviations
* Updates the descriptions and adds Lucene links
* Reformats parameter definitions
* Adds analyze and custom analyzer snippets
* Adds explanations of token types to keep types token filter and tokenizer docs
@jrodewig
Copy link
Contributor Author

jrodewig commented Dec 2, 2019

master: 6ea54ee
7.x: ade72b9
7.5: 7ada1e6
7.4: 22f5835

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…49604)

* Adds title abbreviations
* Updates the descriptions and adds Lucene links
* Reformats parameter definitions
* Adds analyze and custom analyzer snippets
* Adds explanations of token types to keep types token filter and tokenizer docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants