Return 400 when handling invalid JSON #49552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>bug
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
jaymode
approved these changes
Nov 25, 2019
Member
jaymode
left a comment
jaymode
left a comment
There was a problem hiding this comment.
LGTM. Given that this is a bug fix shouldn't we target to 7.x as well?
Contributor
Author
|
Oops, yes, that's an oversight on my part. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix due to transient error |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Nov 25, 2019
Closes elastic#49428. The code that works out an HTTP code for an exception didn't consider the JsonParseException case, meant that an invalid JSON request could result in a 500 Internal Server Error. Now it returns 400 Bad Request.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49428. The code that works out an HTTP code for an exception didn't consider the
JsonParseExceptioncase, meant that an invalid JSON request could result in a 500 Internal Server Error. Now it returns 400 Bad Request.