Skip to content

Conversation

@imotov
Copy link
Contributor

@imotov imotov commented Nov 20, 2019

Brings back support for circles in legacy geo_shape queries that
was accidentally lost during query refactoring.

Fixes #49296

Brings back support for circles in legacy geo_shape queries that
was accidentally lost during query refactoring.

Fixes elastic#49296
@imotov imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.6.0 v7.5.1 labels Nov 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@iverase
Copy link
Contributor

iverase commented Nov 20, 2019

Is there a test that checks we still throw a meaningful error for the BKD case?

@imotov
Copy link
Contributor Author

imotov commented Nov 20, 2019

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/2

@imotov
Copy link
Contributor Author

imotov commented Nov 20, 2019

Is there a test that checks we still throw a meaningful error for the BKD case?

We have a unit test for that.

The error changed a bit, since we detect the issue a bit later when we actually have mapper at hands, but it is still meaningful:

{
  "error": {
    "root_cause": [
      {
        "type": "mapper_parsing_exception",
        "reason": "failed to parse field [location] of type [geo_shape]"
      }
    ],
    "type": "mapper_parsing_exception",
    "reason": "failed to parse field [location] of type [geo_shape]",
    "caused_by": {
      "type": "unsupported_operation_exception",
      "reason": "CIRCLE geometry is not supported"
    }
  },
  "status": 400
}

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov imotov merged commit 0130139 into elastic:master Nov 21, 2019
imotov added a commit that referenced this pull request Nov 21, 2019
Brings back support for circles in legacy geo_shape queries that
was accidentally lost during query refactoring.

Fixes #49296
imotov added a commit that referenced this pull request Nov 21, 2019
Brings back support for circles in legacy geo_shape queries that
was accidentally lost during query refactoring.

Fixes #49296
@jpountz jpountz changed the title Geo: Fix handling of circles in legacy geo_shape queries Fix handling of circles in legacy geo_shape queries Dec 18, 2019
@imotov imotov deleted the issue-49296-add-circle-support-for-legacy-geoshapes branch May 1, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug v7.5.1 v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geo_shape query with circle does not work for legacy geo_shape field

4 participants