Stop ignoring types warnings in REST tests. #49333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>test
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
jtibshirani
force-pushed
the
types-warnings
branch
from
48b5a39 to
c442472
Compare
In 7.x we added logic to the REST test harness to ignore warnings related to types removal. This allowed us to continue to run mixed-cluster tests that included 6.x nodes. Now that master is on 8.x, we've no longer need to include 6.x nodes in testing and have removed almost all typed calls. The logic to ignore warnings can therefore be removed.
jtibshirani
force-pushed
the
types-warnings
branch
from
c442472 to
3e1a440
Compare
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.x we added logic to the REST test harness to ignore warnings related to
types removal. This allowed us to continue to run mixed-cluster tests that
included 6.x nodes.
Now that master is on 8.x, we've no longer need to include 6.x nodes in testing
and have removed almost all typed calls. The logic to ignore warnings can
therefore be removed.
Relates to #35395.