Implement Lucene EstonianAnalyzer, Stemmer #49149
Conversation
|
@elasticcla refresh |
|
Pinging @elastic/es-search (:Search/Analysis) |
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Hi @gpaimla, thanks a lot for your contribution and adding this Lucene analyzer to ES. The change looks great to me in general. I have just one minor ask. Could you add the new analyzer to the documentation page for language analyzers over at docs/reference/analysis/analyzers/lang-analyzer.asciidoc and maybe add the stop word filter to docs/reference/analysis/tokenfilters/stop-tokenfilter.asciidoc?
For the language analyzer page please adapt one of the existing sections about how to reimplement the language analyzer for the case that users need to customize them.
Thanks again, looking forward for these changes after which I will run our CI test suite on the change.
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Great, thanks for the update. I will run the CI tests and merge if they pass or get back to you if the PR needs some more changes (which I doubt).
|
@elasticmachine test this please |
This PR adds a new analyzer and stemmer for the Estonian language. Closes #48895
|
Thanks again @gpaimla for working on this. I merged the PR to master and our 7.x branch which should be used for the 7.6 release. |
5 participants
This PR adds a new analyzer and stemmer for the Estonian language.
Closes #48895