Skip to content

Conversation

@ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Nov 12, 2019

Honours allocation filtering rules when auto-expanding indices.

@ywelsch ywelsch added >enhancement :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.6.0 labels Nov 12, 2019
@ywelsch ywelsch requested a review from DaveCTurner November 12, 2019 07:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Allocation)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

final String node_1 = nodesIds.get(1);
assertThat(cluster().size(), equalTo(2));

logger.info("--> creating an index with no replicas");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not no replicas

@DaveCTurner
Copy link
Contributor

One comment, however, is that I don't think this API generalises to one that would address #2869.

@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 15, 2019

One comment, however, is that I don't think this API generalises to one that would address #2869.

That was a non-goal here. I don't think that there's a general solution for #2869, so would like to focus on the use cases that we can solve.

Note that I've pushed 972af8b to revise the comment in the docs about auto-expand replicas and shard allocation rules.

@ywelsch ywelsch merged commit 18c2aab into elastic:master Nov 15, 2019
ywelsch added a commit that referenced this pull request Nov 18, 2019
Honours allocation filtering rules when auto-expanding indices.
ywelsch added a commit that referenced this pull request Dec 20, 2019
…graded (#50361)

Follow-up to #48974 that ensures that replicas are only auto-expanded according to allocation
filtering rules once all nodes are upgraded to a version that supports this. Helps with
orchestrating cluster upgrades.
ywelsch added a commit that referenced this pull request Dec 20, 2019
…graded (#50361)

Follow-up to #48974 that ensures that replicas are only auto-expanded according to allocation
filtering rules once all nodes are upgraded to a version that supports this. Helps with
orchestrating cluster upgrades.
ywelsch added a commit that referenced this pull request Dec 20, 2019
…graded (#50361)

Follow-up to #48974 that ensures that replicas are only auto-expanded according to allocation
filtering rules once all nodes are upgraded to a version that supports this. Helps with
orchestrating cluster upgrades.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…graded (elastic#50361)

Follow-up to elastic#48974 that ensures that replicas are only auto-expanded according to allocation
filtering rules once all nodes are upgraded to a version that supports this. Helps with
orchestrating cluster upgrades.
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >enhancement v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants